[lkml]   [2004]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRE: [PATCH] Allow cluster-wide flock
    I missed Ken's original mail this morning, so apologies for breaking the

    So I have 2 comments:

    Firstly, it would be nice to throw out the existing wait loop in
    sys_flock(), and replace it with a call to this new
    flock_lock_file_wait(). I suppose that can be done in a separate cleanup
    patch, though...

    More importantly, though, I'm concerned that the overloading of
    f_op->lock() may break behaviour on NFS and CIFS.
    NFS currently has a test in nfs_lock() that causes it to return -ENOLCK
    if the argument is not a posix lock. I'm planning on changing that by
    implementing a proper flock(), but we need an interim solution that
    doesn't change existing behaviour for people.

    Any comment on the effects on CIFS, Steven?

    One solution that I've already suggested to Ken & co is to use a
    separate f_op->flock() call. That would be my preference, since the
    filesystems have to treat flock and posix locks differently anyway.

    Alternatively, we're going to have to fix up NFS at least (CIFS?) before
    this patch can be applied to the mainline kernel.

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 14:05    [W:0.018 / U:54.152 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site