Messages in this thread | | | Date | Sun, 29 Aug 2004 15:21:11 +0200 | From | "Joachim Bremer" <> | Subject | Re: <no subject> |
| |
Nick Piggin <nickpiggin@yahoo.com.au> schrieb am 29.08.04 14:43:43: > > Joachim Bremer wrote: > > As mentioned before I got even with Nicks patch some errors. Looking > > closer at the source there is is a second "goto page_ok" a few lines > > down the label "page_not_up_to_date". Inserting the same calculating > > code used before the label "readpage_error" fixes the errors on my machine. > > These for instance where failure to do reiserfsck (bread complains on last block > > of device) and compiling the linux-tree (file truncated). > > > > The leads to the same calculation 3 times... > > > > Surely not - there is only 1 way to get to page_not_up_to_date, > and through that path you have already done that calculation and > none of the variables involved have been changed. >
Sure I backed out the other patch - but you are right. It does magically work now with your patch only. maybe it was an interaction with the sound driver which hangs on shutdown so maybe there where some transactions not written or replayed.
Thanks
Joachim
> I think. Put a printk before your goto out, and if it triggers > then I am wrong. > > What errors were you seeing with my patch? (If you applied my patch > to an -mm kernel without first backing out the others then it will > break).
_______________________________________________________________ SMS schreiben mit WEB.DE FreeMail - einfach, schnell und kostenguenstig. Jetzt gleich testen! http://f.web.de/?mc=021192
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |