[lkml]   [2004]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] Update e1000 to use module_param()
    The change to e1000_main.c in

    ChangeSet@1.1722.32.6, 2004-05-27 13:44:06-04:00,
    [PATCH] e1000 7/7: Support for ethtool msglevel based error

    added module_param(debug, ...) to e1000_main.c. Since e1000_param.c
    still uses MODULE_PARM(), this means that one gets

    e1000: Ignoring new-style parameters in presence of obsolete ones

    when e1000 is loaded, so the debug parameter cannot even be set.

    The patch below fixes this by updating e1000_param.c to use
    module_param() as well. Since module_param might make the parameters
    visible in sysfs, I removed the __devinitdata notation from the
    parameter arrays as well, just to be safe.


    Signed-off-by: Roland Dreier <>

    Index: linux-
    --- linux- 2004-08-14 03:55:48.000000000 -0700
    +++ linux- 2004-08-15 08:16:31.109671753 -0700
    @@ -55,9 +55,11 @@
    * over and over (plus this helps to avoid typo bugs).

    +static int param_count;
    #define E1000_PARAM(X, S) \
    -static const int __devinitdata X[E1000_MAX_NIC + 1] = E1000_PARAM_INIT; \
    -MODULE_PARM(X, "1-" __MODULE_STRING(E1000_MAX_NIC) "i"); \
    +static int X[E1000_MAX_NIC + 1] = E1000_PARAM_INIT; \
    +module_param_array(X, int, param_count, 0); \

    /* Transmit Descriptor Count
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at
     \ /
      Last update: 2005-03-22 14:05    [W:0.047 / U:6.804 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site