lkml.org 
[lkml]   [2004]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] HPET driver
Robert Picco <Robert.Picco@hp.com> wrote:
>
> Hi:
>
> The driver supports the High Precision Event Timer. The driver has
> adopted a similar API to the Real Time Clock driver. It can support any
> number of HPET devices and the maximum number of timers per HPET device.
> For further information look at the documentation in the patch.
>
> Thanks to Venki at Intel for testing the driver on X86 hardware with HPET.

From a quick read:

- Impressive lack of code comments!

- The /proc entries seem to be undocumented.

- There are several uses of `volatile' in the driver. Usually this is
either unnecessary or indicates a deeper problem. Are they needed?

- Why is mmap setting VM_SHM?

- hpet_alloc() leaks `hpetp' on error paths

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:03    [W:0.133 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site