Messages in this thread | | | Date | Thu, 13 May 2004 16:42:26 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] HPET driver |
| |
Jeff Garzik <jgarzik@pobox.com> wrote: > > > + vma->vm_flags |= (VM_IO | VM_SHM | VM_LOCKED); > > + vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); > > + addr = __pa(addr); > > where did these flags come from? don't you just want VM_RESERVED?
VM_IO is the way to mark mmapped I/O devices.
vma->vm_flags |= VM_IO;
should be sufficient here.
hm, I'm trying to decrypt how the driver accesses the hardware. It's taking copies of kernel virtual addresses based off hpet_virt_address, but there are no readl's or writel's in there. Is the actual device access done over in time_hpet.c?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |