Messages in this thread | | | From | Dmitry Torokhov <> | Subject | Re: locking in psmouse | Date | Wed, 28 Apr 2004 23:47:46 -0500 |
| |
On Wednesday 28 April 2004 04:30 pm, Pavel Machek wrote: > Hi! > > psmouse-base.c does not have any locking. For example psmouse_command > could race with data coming from the mouse, resulting in problem. This > should fix it. > Pavel
Although I am not arguing that locking might be needed in psmouse module I am somewhat confused how it will help in case of data stream coming from the mouse... If mouse sent a byte before the kernel issue a command then it will be delivered by KBC controller and will be processed by the interrupt handler, probably messing up detection process. That's why as soon as we decide that the device behind PS/2 port is some kind of mouse we disable the stream mode.
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |