Messages in this thread | | | Date | Wed, 31 Mar 2004 17:51:13 -0800 | From | Andrew Morton <> | Subject | Re: [RFC][PATCH 1/3] radix priority search tree - objrmap complexity fix |
| |
Andrea Arcangeli <andrea@suse.de> wrote: > > > Doing a __GFP_FS allocation while holding lock_page() is worrisome. It's > > OK if that page is private, but how do we know that the caller didn't pass > > us some page which is on the LRU? > > it _has_ to be private if it's using rw_swap_page_sync. How can a page > be in a lru if we're going to execute add_to_page_cache on it? That > would be pretty broken in the first place.
An anonymous user page meets these requirements. A did say "anal", but rw_swap_page_sync() is a general-purpose library function and we shouldn't be making assumptions about the type of page which the caller happens to be feeding us.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |