Messages in this thread | | | Date | Thu, 1 Apr 2004 06:05:47 +0100 (BST) | From | Hugh Dickins <> | Subject | Re: [RFC][PATCH 1/3] radix priority search tree - objrmap complexity fix |
| |
On Thu, 1 Apr 2004, Andrea Arcangeli wrote: > On Wed, Mar 31, 2004 at 05:51:13PM -0800, Andrew Morton wrote: > > rw_swap_page_sync() is a general-purpose library function and we shouldn't > > be making assumptions about the type of page which the caller happens to be > > feeding us. > > that is a specialized backdoor to do I/O on _private_ pages, it's not a > general-purpose library function for doing anonymous pages
I'm not against anal checks (except personally :), but I'm very much with Andrea on this: rw_swap_page_sync is horrid, but does manage to do a particular job. The header page is great fun: sys_swapon and mkswap read and write it by a totally different route, I shudder (especially when it's a swapfile with blocksize less than pagesize). It would be nice to make it more general and correct, but that's not something you should get stuck on right now.
Hugh
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |