Messages in this thread | | | Date | Thu, 5 Feb 2004 13:16:48 +0100 | From | Pavel Machek <> | Subject | Re: kgdb support in vanilla 2.6.2 |
| |
Hi!
> > need to take a look at such things and really convice ourselves that > > they're worthwhile. Personally, I'd only be interested in the basic stub. > > What I found always extremly ugly in the i386 stub was that it uses > magic globals to talk to the page fault handler. For the x86-64 > version I replaced that by just using __get/__put_user in the memory > accesses, which is much cleaner. I would suggest doing that for i386 > too. > > Also what's also ugly in i386 is that it uses ugly hooks in traps.c/fault.c. > On x86-64 I instead added generic notifiers (see include/asm-x86_64/die.h > and notify_die in arch/x86_64/kernel/traps.c) > where both kdb and kgdb and possibly dprobes and other debuggers can hook > in without conflicting patches for the same files from everybody. > I would strongly suggest to adopt such a generic framework for i386 too > to clean up the core kernel <-> debugger interaction. As soon as this > frame work is in just dropping the stub is is very clean. > > The x86-64 version should be pretty simple to port to i386 if someone > is interested ...
Hmm, this tells me that perhaps it is reasonable to get amd64 version in first, since it received lot of cleaning already... Pavel -- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |