lkml.org 
[lkml]   [2004]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] Disable useless bootmem warning


This bootmem warning has been annoying me forever:

hm, page 000f5000 reserved twice.
hm, page 000f6000 reserved twice.
hm, page 000f1000 reserved twice.
hm, page 000f2000 reserved twice.

It happens because the i386/x86-64 boot code prereserves the mptable and then later bootmem
tries to reserve it again because it's marked reserved in the e820 map.

I've never seen a bug uncovered by this warning too. I considered to disable it
by passing a special array of "ok to reserve twice" regions, but on second thought
it is just best to remove it completely. Reserving things twice is not usually
an error.

This patch does this.

-Andi

--- linux-2.6.3rc2-amd64/mm/bootmem.c-o 2004-02-11 22:06:58.000000000 +0100
+++ linux-2.6.3rc2-amd64/mm/bootmem.c 2004-02-16 17:52:05.000000000 +0100
@@ -91,8 +91,7 @@
if (end > bdata->node_low_pfn)
BUG();
for (i = sidx; i < eidx; i++)
- if (test_and_set_bit(i, bdata->node_bootmem_map))
- printk("hm, page %08lx reserved twice.\n", i*PAGE_SIZE);
+ set_bit(i, bdata->node_bootmem_map);
}

static void __init free_bootmem_core(bootmem_data_t *bdata, unsigned long addr, unsigned long size)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 14:00    [W:0.026 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site