Messages in this thread Patch in this message | | | Date | Sun, 15 Feb 2004 23:29:29 -0800 | From | carbonated beverage <> | Subject | 2.4.24 link err for sparc64 |
| |
Hi all,
I ripped out sysctl support from a 2.4.24 kernel (stock tarball from ftp.*.*.kernel.org) and the final link failed with:
arch/sparc64/kernel/kernel.o(.text+0x19750): In function `sys32_sysctl': : undefined reference to `do_sysctl'
I tossed an #ifndef CONFIG_SYSCTL...#else...#endif guard around arch/sparc64/kernel/sys_sparc32.c file in the sys32_sysctl() function so it returns -ENOTSUPP, but I'm not sure that's the right fix. Should it be in do_sysctl() instead?
Can anyone comment on this?
--- arch/sparc64/kernel/sys_sparc32.c.old 2003-11-28 10:26:19.000000000 -0800 +++ arch/sparc64/kernel/sys_sparc32.c 2004-02-15 23:21:18.304035000 -0800 @@ -4454,6 +4454,9 @@ extern asmlinkage long sys32_sysctl(struct __sysctl_args32 *args) { +#ifndef CONFIG_SYSCTL + return -ENOTSUPP; +#else struct __sysctl_args32 tmp; int error; size_t oldlen, *oldlenp = NULL; @@ -4488,4 +4491,5 @@ copy_to_user(args->__unused, tmp.__unused, sizeof(tmp.__unused)); } return error; +#endif } -- DN Daniel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |