Messages in this thread | | | Date | Tue, 21 Dec 2004 13:46:23 -0800 | From | Greg KH <> | Subject | Re: [PATCH] add legacy resources to sysfs |
| |
On Tue, Dec 21, 2004 at 12:47:44PM -0800, Jesse Barnes wrote: > Here's a rediff against Greg's current tree. It adds legacy_io and legacy_mem > files to each PCI bus directory in sysfs for use by applications that want to > do old school ISA style programming from userspace. > > I'm not sure I've got the sysfs file creation correct, Greg? Am I passing the > wrong thing around? The compile warnings in pci-sysfs.c for the new routines > seem to indicate that... Basically I need to get to a pci_bus structure from > the read/write/mmap routines, and that should be accessible from the kobject > somewhere, right?
You are passing the wrong things around :)
A struct pci_bus is a struct class_device, not a struct device. I think you need to rethink your goal of putting the files into the pci device directory, or just put the files into the proper /sys/class/pci_bus/* directory as your code assumes is happening.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |