lkml.org 
[lkml]   [2004]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] add legacy resources to sysfs
On Tue, Dec 21, 2004 at 09:28:39PM +0000, Matthew Wilcox wrote:
> > ===== arch/ia64/sn/pci/pci_dma.c 1.2 vs edited =====
> > +int sn_pci_get_legacy_mem(struct pci_bus *bus, unsigned long *addr)
> > +{
> > + if (!SN_PCIBUS_BUSSOFT(bus))
> > + return -ENODEV;
> > +
> > + *addr = SN_PCIBUS_BUSSOFT(bus)->bs_legacy_mem | __IA64_UNCACHED_OFFSET;
> > +
> > + return 0;
> > +}
>
> int sn_pci_get_legacy_mem(struct pci_bus *bus)
> {
> if (!SN_PCIBUS_BUSSOFT(bus))
> return ERR_PTR(-ENODEV);

Huh? A pointer doesn't fit into an int on all arches. I think the
original was correct.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [W:0.061 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site