Messages in this thread | | | Date | Tue, 16 Nov 2004 14:18:41 -0600 | From | Dean Nelson <> | Subject | Re: [Patch] export sched_setscheduler() for kernel module use |
| |
On Tue, Nov 16, 2004 at 11:48:21AM +0100, Ingo Molnar wrote: > > * Dean Nelson <dcn@sgi.com> wrote: > > > On Mon, Nov 15, 2004 at 10:58:01AM -0800, Chris Wright wrote: > > > * Dean Nelson (dcn@sgi.com) wrote: > > > > +int do_sched_setscheduler(pid_t pid, int policy, struct sched_param __user *param) > > > > > > this should be static. > > > > You're right. I made another change in that one now passes the > > task_struct pointer to sched_setscheduler() instead of the pid. This > > requires that the caller of sched_setscheduler() hold the > > tasklist_lock. The new patch for people's feedback follows. > > could you make sched_setscheduler() also include a parameter for the > nice value, so that ->static_prio could be set at the same time too > (which would have relevance if SCHED_OTHER is used)? This would make it > a generic kernel-internal API to change all the priority parameters. > Looks good otherwise.
Yeah, I can do that. I'll probably be getting back to you with a question or two, if what you're after isn't obvious once I start making the changes for the nice parameter.
Thanks, Dean - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |