Messages in this thread Patch in this message | | | Date | Wed, 10 Nov 2004 20:48:09 -0800 | From | Tim Hockin <> | Subject | small PCI probe patch for odd 64 bit BARs |
| |
The current PCI probe code breaks for 64 bit BARs that do not decode a full 64 bits. Example:
We have a device that uses a 64 bit BAR. When you write all Fs to the BARs, you get:
000000ff ffff0000
It wants 64k, in the first TB of RAM. The current code totally borks on this.
Simple patch against 2.6.9:
Signed-Off-By: Tim Hockin <thockin@google.com>
--- drivers/pci/probe.c.orig 2004-11-10 20:42:03.000000000 -0800 +++ drivers/pci/probe.c 2004-11-10 20:42:07.000000000 -0800 @@ -144,9 +144,11 @@ pci_write_config_dword(dev, reg+4, ~0); pci_read_config_dword(dev, reg+4, &sz); pci_write_config_dword(dev, reg+4, l); - if (~sz) - res->end = res->start + 0xffffffff + - (((unsigned long) ~sz) << 32); + sz = pci_size(sz, 0xffffffff); + if (sz) { + /* this BAR needs > 4GB? Wow. */ + res->end |= (unsigned long)sz<<32; + } #else if (l) { printk(KERN_ERR "PCI: Unable to handle 64-bit address for device %s\n", pci_name(dev));
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |