Messages in this thread | | | Date | Wed, 20 Oct 2004 21:58:40 -0700 | From | "David S. Miller" <> | Subject | Re: [PATCH] Make netif_rx_ni preempt-safe |
| |
On Thu, 21 Oct 2004 10:35:03 +1000 Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Wed, Oct 20, 2004 at 05:15:08PM -0700, David S. Miller wrote: > > > > +int netif_rx_ni(struct sk_buff *skb) > > +{ > > + int err = netif_rx(skb); > > + > > + preempt_disable(); > > + if (softirq_pending(smp_processor_id())) > > + do_softirq(); > > You need to move the netif_rx call inside the disable as otherwise > you might be checking the pending flag on the wrong CPU.
Good catch, I've made that fix in my tree.
Thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |