lkml.org 
[lkml]   [2004]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] Make netif_rx_ni preempt-safe
    From
    On Wed, Oct 20, 2004 at 05:15:08PM -0700, David S. Miller wrote:
    >
    > +int netif_rx_ni(struct sk_buff *skb)
    > +{
    > + int err = netif_rx(skb);
    > +
    > + preempt_disable();
    > + if (softirq_pending(smp_processor_id()))
    > + do_softirq();

    You need to move the netif_rx call inside the disable as otherwise
    you might be checking the pending flag on the wrong CPU.

    Cheers,
    --
    Visit Openswan at http://www.openswan.org/
    Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:07    [W:0.020 / U:60.512 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site