lkml.org 
[lkml]   [2004]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.2-rc2-mm2
On Fri, Jan 30, 2004 at 11:47:01AM -0800, Andrew Morton wrote:
> > directly calling sys_ANYTHING sounds really wrong to me...

It sounded wrong to me, but it gets done ALL OVER.

> Tim, I do think it would be neater to add another entry point in sys.c for
> nfsd and just do a memcpy.

Do you prefer:

a) make a function
sys.c: ksetgroups(int gidsetsize, gid_t *grouplist)
which does the same as sys_setgroups, but without the copy_from_user()
stuff? The only user (for now, maybe ever) is nfsd.

b) make a function
sys.c: nfsd_setgroups(int gidsetsize, gid_t *grouplist)
which does the same as sys_setgroups, but without the copy_from_user()

c) make the nfsd code build a struct group_info and call
set_current_groups()

--
Tim Hockin
Sun Microsystems, Linux Software Engineering
thockin@sun.com
All opinions are my own, not Sun's
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:00    [W:0.108 / U:1.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site