Messages in this thread | | | Date | Fri, 30 Jan 2004 20:55:15 +0100 | From | Arjan van de Ven <> | Subject | Re: 2.6.2-rc2-mm2 |
| |
On Fri, Jan 30, 2004 at 11:47:01AM -0800, Andrew Morton wrote: > Arjan van de Ven <arjanv@redhat.com> wrote: > > > > > > directly calling sys_ANYTHING sounds really wrong to me... > > > > It's a philosophical thing. Is a kernel thread like a user process which > happens to be running from the kernel or it is a piece of mainline kernel > code which happens to have its own execution context? I rather favour the > latter... > > In this case it looks like it will just happen to work, because > nfsd_setuser() is executed by nfsd, and kernel threads are allowed to do > copy_from_user() with the source in kernel memory. ick.
I didn't imply illegal, just ick ;)
[unhandled content-type:application/pgp-signature] | |