Messages in this thread Patch in this message | | | From | Andries.Brouwer@cwi ... | Date | Tue, 27 Jan 2004 05:07:50 +0100 (MET) | Subject | Re: [uPATCH] refuse plain ufs mount |
| |
From: Linus Torvalds <torvalds@osdl.org>
> But you see, it wasn't the user at all, and it wasn't a ufs filesystem. > It is kernel probing that causes error messages. That is unwanted. > So, your version is wrong.
Yes.
However, I think the _real_ bug is that we have reiserfs near the tail of filesystems to try.
Can you test that alternate patch instead?
Funny how we alternate - when I choose the pure, theoretical point of view you prefer practice, when I prefer practice you become pure.
This time you prefer practice: the list of filesystems is full of garbage and good filesystems should be near the top. I prefer theory: the kernel should not probe at all, so everybody who forgets rootfstype= gets what he deserves.
Be that as it may - below a patch as I suppose you had in mind. I don't like it very much. Ordering constraints in makefiles are bad.
Have not compiled or tested. You can apply it I suppose, but after doing so my earlier patch is still meaningful. Maybe you should also apply that (and the Doc update).
Andries
diff -u --recursive --new-file -X /linux/dontdiff a/fs/Makefile b/fs/Makefile --- a/fs/Makefile 2003-12-18 03:58:57.000000000 +0100 +++ b/fs/Makefile 2004-01-27 04:51:33.000000000 +0100 @@ -48,6 +48,7 @@ obj-$(CONFIG_EXT3_FS) += ext3/ # Before ext2 so root fs can be ext3 obj-$(CONFIG_JBD) += jbd/ obj-$(CONFIG_EXT2_FS) += ext2/ +obj-$(CONFIG_REISERFS_FS) += reiserfs/ obj-$(CONFIG_CRAMFS) += cramfs/ obj-$(CONFIG_RAMFS) += ramfs/ obj-$(CONFIG_HUGETLBFS) += hugetlbfs/ @@ -84,7 +85,6 @@ obj-$(CONFIG_AUTOFS_FS) += autofs/ obj-$(CONFIG_AUTOFS4_FS) += autofs4/ obj-$(CONFIG_ADFS_FS) += adfs/ -obj-$(CONFIG_REISERFS_FS) += reiserfs/ obj-$(CONFIG_UDF_FS) += udf/ obj-$(CONFIG_SUN_OPENPROMFS) += openpromfs/ obj-$(CONFIG_JFS_FS) += jfs/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |