lkml.org 
[lkml]   [2003]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] Missing memory barrier on net/core/dev.c
	Hi Dave,

I *think* net/core/dev.c is missing a mb() before calling
schedule_timoeut.

Feel free to prove me wrong, though ;)

Patch against 2.6.0-test5.

Please review.

Cheers,

Felipe
--- linux-2.6.0-test5/net/core/dev.c Mon Sep 8 16:50:06 2003
+++ linux-2.6.0-test5-fwd/net/core/dev.c Tue Sep 9 14:52:48 2003
@@ -2753,9 +2753,9 @@
rebroadcast_time = jiffies;
}

- current->state = TASK_INTERRUPTIBLE;
+ set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(HZ / 4);
- current->state = TASK_RUNNING;
+ __set_current_state(TASK_RUNNING);

if (time_after(jiffies, warning_time + 10 * HZ)) {
printk(KERN_EMERG "unregister_netdevice: "
\
 
 \ /
  Last update: 2005-03-22 13:48    [W:0.033 / U:1.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site