lkml.org 
[lkml]   [2003]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
Subject[PATCH] IDE: Fix request handling with ide-default & ATAPI
Hi Bart & Linus !

This patch fixes a bug that happens when a request gets to the
IDE layer for a drive using ide-default (that is with no
subdriver attached), like a Power Management request. In this
case, the core will wait for the device status to match
drive->read_stat, but that field contains by default a value
that is not suitable for ATAPI devices. This patch fixes it.

Linus, please apply (already validated with Bart)

diff -urN linux-2.5/drivers/ide/ide-default.c linuxppc-2.5-benh/drivers/ide/ide-default.c
--- linux-2.5/drivers/ide/ide-default.c 2003-09-09 20:15:34.000000000 +0200
+++ linuxppc-2.5-benh/drivers/ide/ide-default.c 2003-09-09 20:05:50.000000000 +0200
@@ -57,6 +57,14 @@
"driver with ide.c\n", drive->name);
return 1;
}
+
+ /* For the sake of the request layer, we must make sure we have a
+ * correct ready_stat value, that is 0 for ATAPI devices or we will
+ * fail any request like Power Management
+ */
+ if (drive->media != ide_disk)
+ drive->ready_stat = 0;
+
return 0;
}


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:48    [W:0.052 / U:1.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site