Messages in this thread | | | From | Andries.Brouwer@cwi ... | Date | Wed, 6 Aug 2003 09:09:43 +0200 (MEST) | Subject | Re: [PATCH] fix error return get/set_native_max functions |
| |
> Giant patch? :( Can you split it?
Of course.
A moment ago I split off the third part. More will follow. (1 was bookkeeping in sector_t, 2 was addr++ fix).
This third part takes code that was repeated three times, namely a debugging printout of the IDENTIFY DEVICE result, and leaves only a single copy, that moreover is a bit more correct.
One of the things that were wrong in the debugging part is also wrong in the non-debugging part, namely the ordering of the bitfields on a bigendian architecture. Probably that will be the next installment.
Let me send this in four subparts. Three parts that remove the debugging code, and one part that adds a single copy, in a new file ide-identify.h that contains stuff that will also correct and simplify other code.
Andries - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |