lkml.org 
[lkml]   [2003]   [Aug]   [12]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
DateTue, 12 Aug 2003 01:43:48 -0400 (EDT)
FromZwane Mwaikambo <>
Subject[PATCH][2.6-mm] cpumask_t - flush_tlb_others warning
arch/x86_64/kernel/smp.c: In function `flush_tlb_others':
arch/x86_64/kernel/smp.c:262: warning: passing arg 1 of `bitmap_or' 
discards qualifiers from pointer target type
arch/x86_64/kernel/smp.c:262: warning: passing arg 3 of `bitmap_or' 
discards qualifiers from pointer target type
arch/x86_64/kernel/smp.c:270: warning: passing arg 1 of `bitmap_empty' 
discards qualifiers from pointer target type

Index: linux-2.6.0-test3-x86_64/arch/x86_64/kernel/smp.c
===================================================================
RCS file: /build/cvsroot/linux-2.6.0-test3/arch/x86_64/kernel/smp.c,v
retrieving revision 1.2
diff -u -p -B -r1.2 smp.c
--- linux-2.6.0-test3-x86_64/arch/x86_64/kernel/smp.c	12 Aug 2003 04:37:27 -0000	1.2
+++ linux-2.6.0-test3-x86_64/arch/x86_64/kernel/smp.c	12 Aug 2003 04:55:01 -0000
@@ -134,7 +134,7 @@ static inline void send_IPI_mask(cpumask
  *	Optimizations Manfred Spraul <manfred@colorfullife.com>
  */
 
-static volatile cpumask_t flush_cpumask;
+static cpumask_t flush_cpumask;
 static struct mm_struct * flush_mm;
 static unsigned long flush_va;
 static spinlock_t tlbstate_lock = SPIN_LOCK_UNLOCKED;
@@ -268,7 +268,7 @@ static void flush_tlb_others(cpumask_t c
 	send_IPI_mask(cpumask, INVALIDATE_TLB_VECTOR);
 
 	while (!cpus_empty(flush_cpumask))
-		/* nothing. lockup detection does not belong here */;
+		mb();	/* nothing. lockup detection does not belong here */;
 
 	flush_mm = NULL;
 	flush_va = 0;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 13:47    [from the cache]
©2003-2008