Messages in this thread | | | Subject | RE: [PATCH] reduce stack in cpqarray.c::ida_ioctl() | Date | Thu, 3 Apr 2003 14:18:57 -0600 | From | "Cameron, Steve" <> |
| |
> This patch to 2.5.66 reduces stack usage in ida_ioctl() by about > 0x500 bytes (on x86).
Looks ok to me, (but i haven't tried it.)
> > There is a possibility that the allocation here should be done one time > only and the buffer pointer saved for re-use instead of allocating it > on each call to ida_ioctl. If that's desirable, I'll have a few > questions.
No, I don't think so. I think we should allow for the possibllity of concurrent calls to this ioctl. (whether linux allows it is another question. I think it used to be the case that only one ioctl could get in at a time... I can't recall if it's still that way.)
-- steve
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |