Messages in this thread Patch in this message | | | Date | Sat, 1 Mar 2003 02:06:57 -0500 (EST) | From | Zwane Mwaikambo <> | Subject | [PATCH][2.5] rename vector to irq |
| |
Variable renaming may be generally frowned upon, but i think the variable name 'vector' really confuses things at this specific code location seeing as it's not actually a vector as referred to for the IDT. With the idt_descr and irq_entries_start being really closely knit it can really confuse someone new to the code.
Index: linux-2.5.62-lse/arch/i386/kernel/entry.S =================================================================== RCS file: /build/cvsroot/linux-2.5.62/arch/i386/kernel/entry.S,v retrieving revision 1.1.1.1 diff -u -r1.1.1.1 entry.S --- linux-2.5.62-lse/arch/i386/kernel/entry.S 18 Feb 2003 00:16:06 -0000 1.1.1.1 +++ linux-2.5.62-lse/arch/i386/kernel/entry.S 1 Mar 2003 06:58:39 -0000 @@ -376,16 +376,16 @@ ENTRY(interrupt) .text -vector=0 +irq=0 ENTRY(irq_entries_start) .rept NR_IRQS ALIGN -1: pushl $vector-256 +1: pushl $irq-256 jmp common_interrupt .data .long 1b .text -vector=vector+1 +irq=irq+1 .endr ALIGN - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |