Messages in this thread Patch in this message | | | Date | Fri, 14 Feb 2003 03:19:49 -0500 (EST) | From | Zwane Mwaikambo <> | Subject | [PATCH][2.5] small PPC32 smp_message_pass buglet |
| |
Looks like this define is missing a brace, otherwise we might just hit a NULL dereference.
Index: linux-2.5.60-uml/arch/ppc/kernel/smp.c =================================================================== RCS file: /build/cvsroot/linux-2.5.60/arch/ppc/kernel/smp.c,v retrieving revision 1.1.1.1 diff -u -r1.1.1.1 smp.c --- linux-2.5.60-uml/arch/ppc/kernel/smp.c 10 Feb 2003 22:14:40 -0000 1.1.1.1 +++ linux-2.5.60-uml/arch/ppc/kernel/smp.c 14 Feb 2003 06:46:37 -0000 @@ -78,9 +78,10 @@ #define PPC_MSG_XMON_BREAK 3 #define smp_message_pass(t,m,d,w) \ - do { if (smp_ops) \ + do { if (smp_ops) {\ atomic_inc(&ipi_sent); \ smp_ops->message_pass((t),(m),(d),(w)); \ + } \ } while(0) /* -- function.linuxpower.ca - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |