Messages in this thread | | | Date | Wed, 10 Dec 2003 11:00:39 +0100 | From | Mikael Pettersson <> | Subject | Re: Fixes for nforce2 hard lockup, apic, io-apic, udma133 covered |
| |
Jesse Allen writes: > --- linux/arch/i386/kernel/apic.c 2003-10-25 11:44:59.000000000 -0700 > +++ linux-jla/arch/i386/kernel/apic.c 2003-12-09 19:07:19.000000000 -0700 > @@ -1089,6 +1089,16 @@ > */ > irq_stat[cpu].apic_timer_irqs++; > > +#ifdef CONFIG_MK7 && CONFIG_BLK_DEV_AMD74XX > + > + /* > + * on 2200XP & nforce2 chipset we need at least 500ns delay here > + * to stop lockups with udma100 drive. try to scale delay time > + * with cpu speed. Ross Dickson. > + */ > + ndelay((cpu_khz >> 12)+200 ); /* don't ack too soon or hard lockup */ > +#endif > + > /* > * NOTE! We'd better ACK the irq immediately, > * because timer handling can be slow.
This is too much of a kludge. APIC timer ACKing is supposed to be fast. Please try without this delay but with the disconnect PCI quirk.
If the delay is still needed even when disconnect is disabled, _then_ can discuss how to do the delay properly.
/Mikael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |