Messages in this thread Patch in this message | | | From | Rusty Russell <> | Subject | [PATCH] streq() | Date | Tue, 24 Sep 2002 14:49:41 +1000 |
| |
Embarrassing, huh? But I just found a bug in my code cause by "if (strcmp(a,b))" instead of "if (!strcmp(a,b))".
This bites me about once a year, so Linus, please apply.
Preparing to have my "3l33t k3rN31 h@ck3r" card revoked, Rusty.
Name: streq implementation Author: Rusty Russell Status: Trivial
D: I can't believe that after all these years I still make the "sense D: of strcmp" mistake. So it's time to reintroduce my favorite macro.
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.5.38/include/linux/string.h working-2.5.38-streq/include/linux/string.h --- linux-2.5.38/include/linux/string.h 2002-06-06 21:38:40.000000000 +1000 +++ working-2.5.38-streq/include/linux/string.h 2002-09-24 14:43:30.000000000 +1000 @@ -15,7 +15,7 @@ extern "C" { extern char * strpbrk(const char *,const char *); extern char * strsep(char **,const char *); extern __kernel_size_t strspn(const char *,const char *); - +#define streq(a,b) (strcmp((a),(b)) == 0) /* * Include machine specific inline routines -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |