lkml.org 
[lkml]   [2002]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: [PATCH] BUG(): sched.c: Line 944
    From
    Date
    On Tue, 2002-09-17 at 16:58, Steven Cole wrote:

    > Sorry, it hung so badly that it didn't respond to that.

    I fixed the hang. If you notice the problem, please do not laugh.

    The attached patch, against 2.5.36, should work fine...

    Robert Love

    diff -urN linux-2.5.36/kernel/sched.c linux/kernel/sched.c
    --- linux-2.5.36/kernel/sched.c Tue Sep 17 20:58:48 2002
    +++ linux/kernel/sched.c Wed Sep 18 00:41:09 2002
    @@ -940,9 +940,6 @@
    struct list_head *queue;
    int idx;

    - if (unlikely(in_atomic()))
    - BUG();
    -
    #if CONFIG_DEBUG_HIGHMEM
    check_highmem_ptes();
    #endif
    @@ -950,8 +947,20 @@
    preempt_disable();
    prev = current;
    rq = this_rq();
    -
    release_kernel_lock(prev);
    +
    + /*
    + * Test if we are atomic. Since do_exit() needs to call into
    + * schedule() atomically, we ignore that for now. Otherwise,
    + * whine if we are scheduling when we should not be.
    + */
    + if (likely(current->state != TASK_ZOMBIE)) {
    + if (unlikely((preempt_count() & ~PREEMPT_ACTIVE) != 1)) {
    + printk(KERN_ERR "scheduling while non-atomic!\n");
    + dump_stack();
    + }
    + }
    +
    prev->sleep_timestamp = jiffies;
    spin_lock_irq(&rq->lock);

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 12:52    [W:0.018 / U:19.432 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site