lkml.org 
[lkml]   [2002]   [Sep]   [13]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateFri, 13 Sep 2002 20:01:14 +0200
FromAndreas Steinmetz <>
SubjectRe: 2.5.34: IR __FUNCTION__ breakage
(rct@gherkin.frus.com removed from cc list as his mta treats (not only) 
my mails as spam...)

Ahmed Masud wrote:
> Thunder from the hill wrote:
> 
>> Hi,
>>
>> On Fri, 13 Sep 2002, Andreas Steinmetz wrote:
>>
>>> At least for gcc 3.2 this would be better:
>>>
>>> #define DERROR(dbg, fmt, args...) \
>>>     do { if (DEBUG_##dbg) \
>>>         printk(KERN_INFO "irnet: %s(): " fmt, __FUNCTION__, ##args); \
>>>     } while(0)
>>>
> Perhaps a hybrid of the two? :
> 
> #define DERROR(dbg, fmt, 
> args...)                                          \
>    do { if (DEBUG_##dbg) {                                                \
>                printk(KERN_INFO "irnet: %s() : ", __FUNCTION__);          \
>                printk(fmt, ## args);                                      \
>         }                                                                 \
>    } while (0)
> 
> 
How about what I did just suggest for smbfs?

#if __GNUC__>=3
#define DERROR(dbg, fmt, args...) \
   do { if (DEBUG_##dbg) \
       printk(KERN_INFO "irnet: %s(): " fmt, __FUNCTION__, ##args); \
   } while(0)
#else
#define DERROR(dbg, args...) \
   {if(DEBUG_##dbg) \
     printk(KERN_INFO "irnet: " __FUNCTION__ "(): " args);}
#endif
gcc 2 versions will be deprecated eventually some time in the future and 
in between the macro selection by gcc major version should be fair enough.
-- 
Andreas Steinmetz
D.O.M. Datenverarbeitung GmbH

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:22    [W:4.354 / U:0.160 seconds]
©2003-2008 Jasper Spaans