lkml.org 
[lkml]   [2002]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.5.34: IR __FUNCTION__ breakage


Thunder from the hill wrote:
> Hi,
>
> On Thu, 12 Sep 2002, Bob_Tracy wrote:
>
>>define DERROR(dbg, args...) \
>> {if(DEBUG_##dbg){\
>> printk(KERN_INFO "irnet: %s(): ", __FUNCTION__);\
>> printk(KERN_INFO args);}}
>>
>>which strikes me as not quite what the author intended, although it
>>should work.
>
>
> Why not
>
> #define DERROR(dbg, fmt, args...) \
> do { if (DEBUG_##dbg) \
> printk(KERN_INFO "irnet: %s(): " fmt, __FUNCTION, args); \
> } while(0)
>
> ?
>
> Thunder

At least for gcc 3.2 this would be better:

#define DERROR(dbg, fmt, args...) \
do { if (DEBUG_##dbg) \
printk(KERN_INFO "irnet: %s(): " fmt, __FUNCTION__, ##args); \
} while(0)

Unfortunately this doesn't work with gcc 2.95.3.

--
Andreas Steinmetz
D.O.M. Datenverarbeitung GmbH

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:28    [W:0.080 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site