Messages in this thread | | | Date | Fri, 26 Jul 2002 12:25:22 +0200 | From | "Heinz J . Mauelshagen" <> | Subject | Re: LVM 1.0.5 patch for Linux 2.4.19-rc3 |
| |
On Fri, Jul 26, 2002 at 02:47:56AM +0200, Marcin Dalecki wrote: > Christoph Hellwig wrote: > > > > +#ifndef uchar > > +typedef unsigned char uchar; > > +#endif > > > > Do you _really_ have to use this non-standard type? can't you use the > > BSD u_char or sysv unchar? and typedef/#define don't really mix nicely.. > > Or of course the normal u8 u16 and u32 and infally u64, which are so > much more explicit about the fact that we are actually dealig with > bit slices. > > > > > All in all this patch would be _soooo_ much easier to review if you wouldn't > > mix random indentation changes with real fixes. > > Christoph applying the patch and rediffing with diffs "ingore white > space' options can help you here. > And plese note that this kind of problems wouldn't be that common > if we finally decided to make indent -kr -i8 mandatory.
It should have been for this patch. Obviously an error on my end.
We'll resend...
--
Regards, Heinz -- The LVM Guy --
*** Software bugs are stupid. Nevertheless it needs not so stupid people to solve them ***
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Heinz Mauelshagen Sistina Software Inc. Senior Consultant/Developer Am Sonnenhang 11 56242 Marienrachdorf Germany Mauelshagen@Sistina.com +49 2626 141200 FAX 924446 =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |