lkml.org 
[lkml]   [2002]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [CHECKER] 37 stack variables >= 1K in 2.4.17
    >> The result of Step One is that the loop no longer touches all
    >> filesystems but lives entirely in namei.c. So, the second patch,
    >> that only changes namei.c can change the recursion into iteration.
    >> Maybe tomorrow or the day after.

    > Obvious breakage: nd->flags can be clobbered by __vfs_follow_link(),
    > so your do_follow_link() and friends are broken.

    Yes, I know. No doubt you are able to fix that by reading that bit
    before calling __vfs_follow_link(). It will be repaired fully
    automatically tomorrow or the day after when __vfs_follow_link()
    disappears altogether.

    But that is the microscopic criticism. I was more interested in
    hearing comments on the global setup.

    Andries
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:26    [W:0.036 / U:0.480 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site