Messages in this thread | | | Subject | Re: [patch] pageattr update | From | Andi Kleen <> | Date | 13 Jun 2002 18:13:37 +0200 |
| |
David Mosberger <davidm@napali.hpl.hp.com> writes:
> As long as change_page_attr() is used for AGP-related stuff only, > there is probably no real issue with the patch in its current form > (its simply a no-op on most non-x86 platforms). However, I'm a bit > worried that someone might start to use it for other things, such that > change_page_attr() could no longer be a no-op on those platforms. > Since the DMA coherency issue is an AGP specific issue, perhaps just > renaming the macro to agp_change_page_attr() would take care of my > concern. What do you think
Linus already requested that for 2.5 (agp_map_into_gart() etc.) I think for 2.4 #ifdef in the agp code is fine and I'm not adopting Ben's change of moving change_page_attr into all asm files.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |