Messages in this thread | | | Date | Tue, 21 May 2002 20:36:37 +0200 | From | Roman Zippel <> | Subject | Re: Linux-2.5.17 |
| |
Hi,
Linus Torvalds wrote:
> I don't think there is any validity any more in the "opaque type" comment, > and I'd rather expose the fact that it _has_ to have the rss computations > inside of it than have more made-up interfaces to hide it. > > The fact is, the rss cannot be computed anywhere else any more, so why > play games about it?
Basically I could agree with it, but something looks wrong. Why exactly is pte_free_tlb() needed in first place? Why does it call tlb_remove_page()? A page mapped into user space has little to do with a page used as page table. Latter is never in the user tlb, so it doesn't need to be removed from it, so calling tlb_remove_page() is just a more complicated way of calling __free_page() or am I missing something?
bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |