| Date | Tue, 21 May 2002 09:06:04 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: Linux-2.5.17 |
| |
On Tue, 21 May 2002, Roman Zippel wrote: > On Mon, 20 May 2002, Linus Torvalds wrote: > > > And yet more TLB shootdown stuff. > > I'm a bit puzzled, how you want to do proper rss accounting, you put now a > "tlb->freed++;" into zap_pte_range(). mmu_gather_t is supposed to be an > opaque type and this access violates this.
I don't think there is any validity any more in the "opaque type" comment, and I'd rather expose the fact that it _has_ to have the rss computations inside of it than have more made-up interfaces to hide it.
The fact is, the rss cannot be computed anywhere else any more, so why play games about it?
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|