lkml.org 
[lkml]   [2002]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] linux-2.5.40_timer-changes_A3 (3/3 - integration)
    From
    Date
    On Wed, 2002-10-02 at 23:59, Greg KH wrote:
    > > +/* fwd declarations */
    >
    > These don't have to be forward declarations, do they?
    > And can they be static?

    Ummm. I could just be wrong, but since I'm setting structure elements to
    equal the functions before they are declared, I need the fwds (unless,
    of course I put the "struct timer_opts timer_pit" section below all the
    functions, which is doable). Also, since external functions are going
    to be calling these functions via the structure's function pointers, I
    believe they can't be static. Although, maybe they can, as long as the
    timer_pit value isn't static. I'm not that much of a C guru, so I'm
    really sure.

    >
    > > +int init_pit(void);
    > > +void mark_offset_pit(void);
    > > +unsigned long get_offset_pit(void);
    > > +
    > > +/* tsc timer_opts struct */
    > > +struct timer_opts timer_pit = {
    > > + init: init_pit,
    > > + mark_offset: mark_offset_pit,
    > > + get_offset: get_offset_pit
    > > +};
    > > +
    > > +
    > > +extern spinlock_t i8259A_lock;
    > > +extern spinlock_t i8253_lock;
    > > +#include "do_timer.h"
    >
    > Shouldn't these 3 lines be above the "/* fwd declarations */" line?

    They could be, but I'm not sure about the necessity. Is this a coding
    style sorta' thing, or a C properness sort of thing? Either way is fine,
    I just don't follow the logic.


    > Same minor comments for timer_tsc.c

    Thanks for the feedback, I'll probably go ahead and apply your
    suggestions, although, I'm still quite ignorant as to the reasons for
    doing so. If you could, please fill me in.

    thanks
    -john


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:29    [W:0.039 / U:61.992 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site