lkml.org 
[lkml]   [2002]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] linux-2.5.40_timer-changes_A3 (3/3 - integration)
    On Wed, Oct 02, 2002 at 11:12:34PM -0700, john stultz wrote:
    > Linus, All,
    >
    > This is the final part 3 of 3 of my timer-change patch. Part 3
    > integrates the moved code (from part 2) into the new infrastructure
    > (from part 1).

    Minor, minor comments:

    > diff -Nru a/arch/i386/kernel/timer_pit.c b/arch/i386/kernel/timer_pit.c
    > --- a/arch/i386/kernel/timer_pit.c Wed Oct 2 22:38:24 2002
    > +++ b/arch/i386/kernel/timer_pit.c Wed Oct 2 22:38:24 2002
    > @@ -1,3 +1,41 @@
    > +/*
    > + * This code largely moved from arch/i386/kernel/time.c.
    > + * See comments there for proper credits.
    > + */
    > +
    > +#include <linux/spinlock.h>
    > +#include <linux/module.h>
    > +#include <linux/device.h>
    > +#include <asm/timer.h>
    > +#include <asm/io.h>
    > +
    > +/* fwd declarations */

    These don't have to be forward declarations, do they?
    And can they be static?

    > +int init_pit(void);
    > +void mark_offset_pit(void);
    > +unsigned long get_offset_pit(void);
    > +
    > +/* tsc timer_opts struct */
    > +struct timer_opts timer_pit = {
    > + init: init_pit,
    > + mark_offset: mark_offset_pit,
    > + get_offset: get_offset_pit
    > +};
    > +
    > +
    > +extern spinlock_t i8259A_lock;
    > +extern spinlock_t i8253_lock;
    > +#include "do_timer.h"

    Shouldn't these 3 lines be above the "/* fwd declarations */" line?

    Same minor comments for timer_tsc.c

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:29    [W:0.039 / U:30.144 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site