lkml.org 
[lkml]   [2002]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRE: [PATCH] hyper-threading information in /proc/cpuinfo
    Date
    Sorry,

    Can you please change "siblings\t" to "threads\t\t". SuSE 8.1, for example,
    is already doing it:

    +#ifdef CONFIG_SMP
    + if (cpu_has_ht) {
    + seq_printf(m, "physical id\t: %d\n", phys_proc_id[n]);
    + seq_printf(m, "threads\t\t: %d\n", smp_num_siblings);
    + }
    +#endif

    Thanks,
    Jun

    -----Original Message-----
    From: Robert Love [mailto:rml@tech9.net]
    Sent: Friday, October 25, 2002 2:40 PM
    To: Robert Love
    Cc: Nakajima, Jun; Alan Cox; 'Dave Jones'; 'akpm@digeo.com';
    'linux-kernel@vger.kernel.org'; 'chrisl@vmware.com'; 'Martin J. Bligh'
    Subject: Re: [PATCH] hyper-threading information in /proc/cpuinfo


    On Fri, 2002-10-25 at 17:30, Robert Love wrote:

    > - wrap print in "if (cpu_has_ht) { ... }" (Dave Jones)
    > - remove initdata from phys_proc_id (Jun Nakajima)
    > - match field names in latest 2.4-ac (Alan Cox)

    missing this last bit, sorry..

    Robert Love

    cpu/proc.c | 7 +++++++
    smpboot.c | 2 +-
    2 files changed, 8 insertions(+), 1 deletion(-)

    diff -urN linux-2.5.44/arch/i386/kernel/cpu/proc.c
    linux/arch/i386/kernel/cpu/proc.c
    --- linux-2.5.44/arch/i386/kernel/cpu/proc.c 2002-10-19
    00:02:29.000000000 -0400
    +++ linux/arch/i386/kernel/cpu/proc.c 2002-10-25 15:18:03.000000000 -0400
    @@ -17,6 +17,7 @@
    * applications want to get the raw CPUID data, they should access
    * /dev/cpu/<cpu_nr>/cpuid instead.
    */
    + extern int phys_proc_id[NR_CPUS];
    static char *x86_cap_flags[] = {
    /* Intel-defined */
    "fpu", "vme", "de", "pse", "tsc", "msr", "pae", "mce",
    @@ -74,6 +75,12 @@
    /* Cache size */
    if (c->x86_cache_size >= 0)
    seq_printf(m, "cache size\t: %d KB\n", c->x86_cache_size);
    +#ifdef CONFIG_SMP
    + if (cpu_has_ht) {
    + seq_printf(m, "physical id\t: %d\n", phys_proc_id[n]);
    + seq_printf(m, "siblings\t: %d\n", smp_num_siblings);
    + }
    +#endif

    /* We use exception 16 if we have hardware math and we've either
    seen it or the CPU claims it is internal */
    fpu_exception = c->hard_math && (ignore_irq13 || cpu_has_fpu);
    diff -urN linux-2.5.44/arch/i386/kernel/smpboot.c
    linux/arch/i386/kernel/smpboot.c
    --- linux-2.5.44/arch/i386/kernel/smpboot.c 2002-10-19
    00:01:53.000000000 -0400
    +++ linux/arch/i386/kernel/smpboot.c 2002-10-25 17:24:26.000000000 -0400
    @@ -58,7 +58,7 @@

    /* Number of siblings per CPU package */
    int smp_num_siblings = 1;
    -int __initdata phys_proc_id[NR_CPUS]; /* Package ID of each logical CPU */
    +int phys_proc_id[NR_CPUS]; /* Package ID of each logical CPU */

    /* Bitmask of currently online CPUs */
    unsigned long cpu_online_map;
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-03-22 13:30    [W:0.023 / U:60.848 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site