Messages in this thread | | | Date | Wed, 14 Feb 2001 05:17:19 -0600 (CST) | From | Jeff Garzik <> | Subject | Re: [patch] 2.4.2-pre3: parport_pc init_module bug |
| |
On Wed, 14 Feb 2001, Andrew Morton wrote:
> Jeff Garzik wrote: > > > > Bad patch. It should be > > > > if (r >= 0) { > > registered_parport = 1; > > if (r > 0) > > count += r; > > } > > > > If pci_register_driver returns < 0, the driver is not registered with > > the system. > > eh? > > pci_register_driver(struct pci_driver *drv) > { > struct pci_dev *dev; > int count = 0; > > list_add_tail(&drv->node, &pci_drivers); > pci_for_each_dev(dev) { > if (!pci_dev_driver(dev)) > count += pci_announce_device(drv, dev); > } > return count; > } > > Maybe you're thinking of pci_module_init?
Apparently :) Oops, sorry Tim.
Oh well, the new patch is a better one anyway ;) Guards against me changing pci_register_driver as such. :)
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |