Messages in this thread |  | | | Date | Wed, 14 Feb 2001 05:40:03 -0600 (CST) | | From | Philipp Rumpf <> | | Subject | Re: [patch] 2.4.2-pre3: parport_pc init_module bug |
| |
On Wed, 14 Feb 2001, Jeff Garzik wrote: > On Wed, 14 Feb 2001, Tim Waugh wrote: > > +/** > > + * pci_find_capability - query for devices' capabilities > > + * @dev: PCI device to query > > + * @cap: capability code > > + * > > + * Tell if a device supports a given PCI capability. > > + * Returns the address of the requested capability structure within the device's PCI > > + * configuration space or 0 in case the device does not support it. > > + * Possible values for @flags: ^^^^^^ @cap would make more sense, no ?
> > + * %PCI_CAP_ID_AGP Accelerated Graphics Port > > + * > > + * %PCI_CAP_ID_VPD Vital Product Data > > + * > > + * %PCI_CAP_ID_SLOTID Slot Identification > > + * > > + * %PCI_CAP_ID_MSI Message Signalled Interrupts > > + * > > + * %PCI_CAP_ID_CHSWP CompactPCI HotSwap > > + */ > > Looks ok, but I wonder if we should include this list in the docs. > These is stuff defined by the PCI spec, and this list could potentially > get longer... (opinions either way wanted...)
I would vote for including those capabilities which are most likely to be used by drivers (PCI_CAP_ID_PM, and maybe _VPD). I'm not sure whether the plan is to have drivers handle MSIs or do it in the generic PCI code. Grant ?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |