lkml.org 
[lkml]   [2000]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[PATCH] thinko in 2.2.17 task file code
Hi Andre,

I remember you were very tired when you wrote this
code. There's a little thinko in it, I believe :

int tasksize = (HDIO_DRIVE_TASK) ?
HDIO_DRIVE_TASK_HDR_SIZE : HDIO_DRIVE_CMD_HDR_SIZE;

should be :

int tasksize = (cmd==HDIO_DRIVE_TASK) ?
HDIO_DRIVE_TASK_HDR_SIZE : HDIO_DRIVE_CMD_HDR_SIZE;

I think this could only cause a 4-bytes overflow when
sending an HDIO_DRIVE_CMD.

anyway, here is the patch attached against
2.2.17-20000904.

Regards,
Willy


___________________________________________________________
Do You Yahoo!?
Achetez, vendez! À votre prix! Sur http://encheres.yahoo.fr[unhandled content-type:application/x-unknown]
\
 
 \ /
  Last update: 2005-03-22 12:41    [W:0.024 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site