Messages in this thread | | | Date | Sat, 1 Jul 2000 18:36:46 -0700 (PDT) | From | Chris Lattner <> | Subject | Re: [PATCH] Make printk lock when appropriate... |
| |
> > "buf" is a static variable, defined in line 28 [printk.c] > > Since vsprintf can definitely be slow, maybe buf could be made per-cpu. > Tradeoff wasting 1K x max_cpus in uninitialized data space versus > locking before vsprintf.
As I mentioned in Patch #2, I don't think this is a great idea either... because the extra buffers would rarely be used and it doesn't fix the recursion stemming from the vsprintf... Also, it would probably be a bad thing to start doing this with "buf" because then you could argue that it should be done for _ALL_ static buffers... :)
Of course, on a NUMA machine with lots of memory... _THAT_ might not be such a bad idea either... ;)
-Chris
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |