Messages in this thread Patch in this message | | | Date | Thu, 3 Sep 1998 02:02:01 +0200 | From | Kurt Garloff <> | Subject | Re: Any SMP people out there with SCSI CD ROMs? |
| |
On Wed, Sep 02, 1998 at 04:17:29PM +0000, Rolf Fokkens wrote: > Having installed a second CPU recentry and having the problem since > then, I respond to an older message. > > > I've gotten lots of reports that SCSI CD's seem to be broken > currently, > > and it's almost certainly because the SCSI layer is doing something > bad > > wrt the io_request_lock under SMP with either ioctl's or just > something > > else in sr.c...
There was a patch to sr_ioctl.c some time ago, and it might or might not help you fix this bug. Please report it back to the list, if you are successful. Patch appended ...
-- Kurt Garloff, Dortmund <K.Garloff@ping.de> PGP key on http://student.physik.uni-dortmund.de/homepages/garloff --- linux/drivers/scsi/sr_ioctl.c.21115 Tue Aug 4 20:50:51 1998 +++ linux/drivers/scsi/sr_ioctl.c Mon Aug 17 21:22:46 1998 @@ -56,7 +56,10 @@ unsigned long flags;
SDev = scsi_CDs[target].device; - SCpnt = scsi_allocate_device(NULL, scsi_CDs[target].device, 1); + + spin_lock_irqsave(&io_request_lock, flags); + SCpnt = scsi_allocate_device(NULL, SDev, 1); + spin_unlock_irqrestore(&io_request_lock, flags);
retry: if( !scsi_block_when_processing_errors(SDev) ) | |