lkml.org 
[lkml]   [1998]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.1.118 Tons of oopes
Linus Torvalds writes:
>
>
> On Wed, 26 Aug 1998, Richard Gooch wrote:
> >
> > Linus: for god's sake, back out the particular patch that did this!
> > Surely we can live with having flush() at the end of the structure?!?!
>
> For Gods sake, when somebody notices the compiler warnings when compiling
> a new module, if he doesn't take them seriously he has only himself to
> blame.
>
> I end up maintaining the end result, and I categorically refuse to make
> bad decisions just because there's going to be a very limited amount of
> pain for a week or two - I end up having to maintain it for _years_. As
> such, my priorities are slightly different than other peoples.

This change affects all in-house drivers that people have written,
it's not limited to drivers shipped with the kernel.

Now, you talk about making "bad decisions". What exactly do you mean
by that? Is your intention that you want people to see the breakage,
look in the sources and figure out what flush() is used for and
determine whether they need to implement it? If so, I don't think
you'll get that effect. I think most driver writers will think "oh,
another optional VFS method: I'll just put NULL here".

Also, where is this new method documented (what it does and why you
need it)?

People with binary-only drivers will have breakage either way with
this change.

People with source code access will now have to edit their drivers
rather than just recompiling. They have to recompile anyway. But why
must they edit their source?

I don't see what the "benefit" to this intentional breakage is. I
don't see a situation where it improves anything.

Regards,

Richard....

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html

\
 
 \ /
  Last update: 2005-03-22 13:44    [W:0.235 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site