lkml.org 
[lkml]   [1998]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: x86 memsize > 1Gb patches.
Pavel Machek writes:

> Bad idea, phys_to_virt(x) translates to (PAGE_OFFSET | x). You do not
> want call overhead on single instruction. (Which is probably exactly
> as long as call instruction).

Here is my opinion: I want the kernel to provide a well-defined,
documented interface to modules. And I also want this interface
to be stable across different configurations, so that modules
keep working even when someone reconfigures their kernel.
In this case, I would go for something like this:

extern void * phys_to_virt(unsigned long);

#if defined(__KERNEL__) && !defined(MODULE)
extern __inline__ void * phys_to_virt(unsigned long address)
{
return __io_virt(address);
}
#endif

Just my opinion. There are other ways to resolve this issue. I think
that we need a policy decision from Linus Torvalds here.

Cheers,

Michael Chastain
<mailto:mec@shout.net>
"love without fear"

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu

\
 
 \ /
  Last update: 2005-03-22 13:41    [W:1.165 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site