lkml.org 
[lkml]   [1998]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Linux-2.1.85: replacement PATCH for ibmmca
Hi Adam,

> + dep_tristate 'IBMMCA SCSI support' CONFIG_SCSI_IBMMCA $CONFIG_SCSI
> + if [ "$CONFIG_SCSI_IBMMCA" != "n" ]; then

There's a problem with this. At the beginning of execution,
CONFIG_SCSI_IBMMCA has the value "". Menuconfig constructs its menus
before interpreting any dep_tristate lines, so this test will result
in the construction of a spurious menu.

The right way to test is:

if [ "$CONFIG_SCSI_IBMMCA" = "y" -o "$CONFIG_SCSI_IBMMCA = "m" ]; then

Trevor Johnson has a patch that fixes all the instances of this in
all the config.in and Config.in files.

Regards,

Michael Chastain
<mailto:mec@shout.net>
"love without fear"

\
 
 \ /
  Last update: 2005-03-22 13:41    [W:0.027 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site