lkml.org 
[lkml]   [1998]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: VIOLENT 2.1.129 serial bug on Alpha.

Although I can't positively say, I don't _think_ it worked. My
machine locked up with no recognizable reason after I messed with some
serial stuff (I was using pppd, then the connection dropped, then...
<sigh> alas, I don't remember).

I was in X at the time, so I never saw which, if any, messages
were logged to the console. The pointer stopped responding, I couldn't
switch VCs, I couldn't... do anything. The machine was locked up hard.

I haven't had time to try debugging it yet. I'll give it a shot
tomorrow, I think.

However, before applying the patch, I did notice at one time
before applying the patch you sent that the usage count for serial.o was
-1. I rebooted shortly thereafter, _before_ the system was torn to
shreds. ;-)

- Bob

On Tue, 24 Nov 1998, Theodore Y. Ts'o wrote:

> Date: Tue, 24 Nov 1998 20:31:00 +0100 (MET)
> From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
>
> Shouldn't all seven references to MOD_DEC_USE_COUNT within rs_open be
> removed? As I see from tty_open (in tty_io.c), rs_close is always called
> after an unsuccessful rs_open. As rs_close always calls
> MOD_DEC_USE_COUNT, there is no need (and it's even harmful) to do this
> from rs_open.
>
> No, because rs_close() only calls MOD_DEC_USE_COUNT if tty->driver_data
> is non-NULL.
>
> The change I submitted was the simplest set of changes which fix the
> problem, without completely revamping how the module in-use counter
> works for the serial driver.
>
> - Ted
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.rutgers.edu
> Please read the FAQ at http://www.tux.org/lkml/
>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:45    [W:0.035 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site