Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 17 May 2024 18:47:00 -0700 | From | Josh Poimboeuf <> | Subject | Re: [PATCH] x86: select ARCH_WANT_FRAME_POINTERS again when UNWINDER_FRAME_POINTER=y |
| |
On Sun, Feb 04, 2024 at 09:20:03PM +0900, Masahiro Yamada wrote: > It took me some time to understand the purpose of the tricky code at > the end of arch/x86/Kconfig.debug. > > Without it, the following would be shown: > > WARNING: unmet direct dependencies detected for FRAME_POINTER > > because commit 81d387190039 ("x86/kconfig: Consolidate unwinders into > multiple choice selection") removed 'select ARCH_WANT_FRAME_POINTERS'. > > The correct and more straightforward approach should have been to move > it where 'select FRAME_POINTER' is located. > > Several architectures properly handle the conditional selection of > ARCH_WANT_FRAME_POINTERS. For example, 'config UNWINDER_FRAME_POINTER' > in arch/arm/Kconfig.debug. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Looks good, thanks for fixing that!
Fixes: 81d387190039 ("x86/kconfig: Consolidate unwinders into multiple choice selection") Acked-by: Josh Poimboeuf <jpoimboe@kernel.org>
-- Josh
| ![\](/images/icornerr.gif) |